lifecycle: outdated step should raise SnapcraftError #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiusens
reviewed
Aug 28, 2017
snapcraft/internal/errors.py
Outdated
| 'snapcraft clean {parts_names} -s {step}\n' | ||
| ) | ||
|
|
||
| def __init__(self, step, part, |
There was a problem hiding this comment.
please add an * after self to force all of these to be kwargs (API clarity in the long wrong)
There was a problem hiding this comment.
Hmm I had it in there before but it didn't seem to work... I guess it was unrelated. Added the * back!
come-maiz
approved these changes
Aug 29, 2017
sergiusens
added
the
Bug
kalikiana
added a commit
to kalikiana/snapcraft
that referenced
this pull request
Sep 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outdated steps should raise derivatives of SnapcraftError