Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lxd: pass SNAPCRAFT_PARTS_URI through into container #1585

Merged
merged 3 commits into from
Oct 6, 2017
Merged

lxd: pass SNAPCRAFT_PARTS_URI through into container #1585

merged 3 commits into from
Oct 6, 2017

Conversation

kalikiana
Copy link
Contributor

@kalikiana kalikiana commented Oct 4, 2017 •
edited

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on bug reports?
  • If this is a new feature. Have you discussed the design on the forum?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh unit?

Fixes: bug 1719951

@kalikiana kalikiana self-assigned this Oct 4, 2017
sergiusens
sergiusens approved these changes Oct 6, 2017
View reviewed changes
Copy link
Collaborator

@sergiusens sergiusens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably wrap setting env vars into a proper method as soon as we add a new one.

@sergiusens sergiusens added this to the 2.35 milestone Oct 6, 2017
@sergiusens sergiusens added the bug Actual bad behavior that don't fall into maintenance or documentation label Oct 6, 2017
@sergiusens sergiusens merged commit 13ea598 into canonical:master Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiusens sergiusens sergiusens approved these changes

Assignees

@kalikiana kalikiana

Labels
bug Actual bad behavior that don't fall into maintenance or documentation
Projects
None yet
Milestone
2.35
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kalikiana @sergiusens