Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "--profile" parameter to cleanbuild #1969

Conversation

chrisglass
Copy link
Contributor

This allows the user to select another LXD profile when running
cleanbuild, in case some profile-specific options are required. This
allows users not to have to change their default profile.

This partially fixes LP:1686766

The change follows the existing pattern (passing an explicit option instead of an "extra options" free-form parameter), as with the existing "--remote" option.

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on bug reports?
  • If this is a new feature. Have you discussed the design on the forum?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh unit?

This allows the user to select another LXD profile when running
cleanbuild, in case some profile-specific options are required. This
allows users not to have to change their default profile.

This partially fixes LP:1686766
@chrisglass
Copy link
Contributor Author

I think that failed check is not related to my code.

@sergiusens
Copy link
Collaborator

Moving forward, we have decided to move away from containers as the mechanism to execute builds https://forum.snapcraft.io/t/draft-consistent-build-environments-build-vms/5374/3

Sorry for the late reply and the wasted effort.

@sergiusens sergiusens closed this May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants