Add licensing support #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| from testtools.matchers import ( | ||
| DirExists, | ||
| FileExists, | ||
| FileContains, |
There was a problem hiding this comment.
FileContains before FileExists, so it's alphabetical.
|
You have here some files without the trailing new line. I think we should adopt the practice of ending all files with a new line. |
|
@chipaca maybe you want to take a look. |
(Closes LP: #1527453)
sergiusens
force-pushed
the
license-support
branch
from
af1ce68
to
31d37b4
Compare
|
@ElOpio I think I gone through all your requests. |
|
👍 |
|
yes, thanks, 👍 |
smoser
pushed a commit
to smoser/snapcraft
that referenced
this pull request
Sep 14, 2016
Revert "Separate provision agent and guest agent"
kalikiana
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
Add licensing support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Closes LP: #1527453)