Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Add licensing support #201
Conversation
elopio
reviewed
Jan 5, 2016
| +from testtools.matchers import ( | ||
| + DirExists, | ||
| + FileExists, | ||
| + FileContains, |
elopio
reviewed
Jan 5, 2016
| + call('file.apparmor', os.path.join(self.meta_dir, | ||
| + 'file.apparmor')), | ||
| + call('file.seccomp', os.path.join(self.meta_dir, | ||
| + 'file.seccomp')), |
elopio
Jan 5, 2016
Member
These three calls are not related to the license. You can use mock.ANY instead, I think here we only care about the license call.
elopio
reviewed
Jan 5, 2016
| + 'snap/bin/bash.wrapper'), | ||
| + args=None, shebang=None, | ||
| + ), | ||
| + ]) |
elopio
Jan 5, 2016
Member
How is this assertion related to the license? You might be testing too much in this test, this seems to me like something to do in a separate test.
elopio
reviewed
Jan 5, 2016
| + | ||
| + expected_message = "'license' is a dependency of 'license-version'" | ||
| + self.assertEqual(raised.exception.message, expected_message, | ||
| + msg=self.data) |
|
You have here some files without the trailing new line. I think we should adopt the practice of ending all files with a new line. |
|
@chipaca maybe you want to take a look. |
|
@elopio I think I gone through all your requests. |
|
|
|
yes, thanks, |
added a commit
that referenced
this pull request
Jan 6, 2016
sergiusens
merged commit 1d5c2a4
into
snapcore:master
Jan 6, 2016
sergiusens
deleted the
sergiusens:license-support
branch
Jan 6, 2016
pushed a commit
to smoser/snapcraft
that referenced
this pull request
Sep 14, 2016
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sergiusens commentedJan 5, 2016
(Closes LP: #1527453)