Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packaging: include changelog for setup.py's version detection #2097

Merged
merged 1 commit into from Apr 23, 2018
Merged

packaging: include changelog for setup.py's version detection #2097

merged 1 commit into from Apr 23, 2018

Conversation

sergiusens
Copy link
Collaborator

@sergiusens sergiusens commented Apr 23, 2018 •
edited

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on bug reports?
  • If this is a new feature. Have you discussed the design on the forum?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh unit?

@sergiusens
packaging: include changelog for setup.py's version detection
8b84e4c 
Include `setup.py` when creating the `sdist` for PyPI so that the version can be
properly set on `pip install` and printed out by `snapcraft --version`.

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@sergiusens sergiusens added the Bug Actual bad behavior that don't fall into maintenance or documentation label Apr 23, 2018
@sergiusens sergiusens self-assigned this Apr 23, 2018
@sergiusens sergiusens added this to the 2.42 milestone Apr 23, 2018
kalikiana
kalikiana reviewed Apr 23, 2018
View reviewed changes
MANIFEST.in
@@ -1,2 +1,3 @@
include libraries/*
include schema/*
include debian/changelog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the code in setup.py perhaps fail if the file isn't present? Assuming we always have it either from git or the dist tarball.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that would break building the snap, it is a larger refactor we can approach together with splitting out debian/changelog from the tree.

@kyrofa kyrofa merged commit f0afbec into canonical:master Apr 23, 2018
@sergiusens sergiusens deleted the sdist-version branch April 23, 2018 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalikiana kalikiana kalikiana left review comments

Assignees

@sergiusens sergiusens

Labels
Bug Actual bad behavior that don't fall into maintenance or documentation
Projects
18.04
Awaiting triage
Milestone
2.42
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sergiusens @kalikiana @kyrofa