lifecycle: don't clean priming area if the snap is being tried #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if one uses 'snap try' and then runs 'snapcraft clean', one must 'snap try' again once the snap has been re-primed. Be smarter about this: check to see if the priming area is being used by 'snap try', and if so, don't remove it when cleaning, just remove its contents. Then once the snap has been re-primed, it'll just start working again, no 'snap try' required. Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
Codecov Report
@@ Coverage Diff @@
## master #2143 +/- ##
==========================================
+ Coverage 91.32% 91.35% +0.02%
==========================================
Files 193 194 +1
Lines 12168 12244 +76
Branches 1814 1820 +6
==========================================
+ Hits 11113 11186 +73
- Misses 714 716 +2
- Partials 341 342 +1
Continue to review full report at Codecov.
|
sergiusens
previously requested changes
May 30, 2018
snapcraft/internal/mountinfo.py
Outdated
| with contextlib.suppress(FileNotFoundError): | ||
| with open(mountinfo_file) as f: | ||
| for row in csv.reader(f, delimiter=' '): | ||
| mount = Mount(row) |
There was a problem hiding this comment.
this can raise a KeyError, if catched, warn and continue would be my choice.
There was a problem hiding this comment.
Good catch, thank you. Fixed.
Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
sergiusens
approved these changes
Jun 4, 2018
Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
kyrofa
force-pushed
the
bugfix/clean_prime_of_tried
branch
from
751a404
to
6222cd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./runtests.sh static?./runtests.sh unit?Currently, if one uses 'snap try' and then runs 'snapcraft clean', one must 'snap try' again once the snap has been re-primed. This PR fixes LP: #1774015 by being smarter about this: checking to see if the priming area is being used by 'snap try', and if so, not removing it when cleaning, just its contents. Then once the snap has been re-primed, it'll just start working again, no 'snap try' required.