lifecycle: automatically clean dirty steps #2145
Conversation
Currently the snapcraft CLI will error out if a given step has already
run, but has changed since doing so (e.g. if a part has been pulled, but
then had a `stage-package` added).
Add support for automatically cleaning the required steps instead of
erroring. Leave today's behavior as the default, but add a configuration
item to enable the new behavior. Simply add the following snippet to
`~/.config/snapcraft/cli.cfg`:
[Lifecycle]
outdated_step_action = clean
Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
kyrofa
force-pushed
the
feature/auto_clean_dirty_steps
branch
from
96cc962
to
43c6721
Compare
Codecov Report
@@ Coverage Diff @@
## master #2145 +/- ##
==========================================
- Coverage 91.02% 91.01% -0.02%
==========================================
Files 193 193
Lines 12182 12200 +18
Branches 1820 1824 +4
==========================================
+ Hits 11089 11104 +15
- Misses 751 753 +2
- Partials 342 343 +1
Continue to review full report at Codecov.
|
| return OutdatedStepAction[action.upper()] | ||
| else: | ||
| # Error by default | ||
| return OutdatedStepAction.ERROR |
There was a problem hiding this comment.
I feel like we want to make the default the new behavior and maybe warn (a couple of times) about how to set the old behavior back.
There was a problem hiding this comment.
I guess I was thinking our team could flip that switch for a release or so to make sure it doesn't bite before flipping it for everyone, but yeah, if you want to flip it now and warn that's fine.
There was a problem hiding this comment.
OK, if we flip ourselves in a near future, that is fine as well, please create a bug task to flip the switch.
./runtests.sh static?./runtests.sh unit?Currently the snapcraft CLI will error out if a given step has already run, but has changed since doing so (e.g. if a part has been pulled, but then had a
stage-packageadded).This PR resolves LP: #1774021 by adding support for automatically cleaning the required steps instead of erroring. It leaves today's behavior as the default, but adds a configuration item to enable the new behavior. Simply add the following snippet to
~/.config/snapcraft/cli.cfg: