Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snap: use apt from the archive instead of compiling #2156

Merged
merged 1 commit into from Jun 7, 2018

Conversation

sergiusens
Copy link
Collaborator

@sergiusens sergiusens commented Jun 4, 2018

Since the introduction of patchelf, it is not necessary to compile apt
anymore, this brings in two important benefits:

  • faster builds
  • automatic USNs for CVEs where apt is affected

Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on bug reports?
  • If this is a new feature. Have you discussed the design on the forum?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh unit?

On bionic the correct apt methods are being used and there is no SIGSEV, ps output follows

sergius+ 30148 30108  6 18:49 pts/3    00:00:04 /snap/snapcraft/x14/usr/bin/python3 /snap/snapcraft/x14/bin/snapcraft pull
sergius+ 30173 30148  0 18:49 pts/3    00:00:00 /snap/snapcraft/x14/usr/lib/apt/methods/http
sergius+ 30174 30148  0 18:49 pts/3    00:00:00 /snap/snapcraft/x14/usr/lib/apt/methods/http
sergius+ 30176 30148  0 18:49 pts/3    00:00:00 /snap/snapcraft/x14/usr/lib/apt/methods/gpgv
sergius+ 30222 30148  1 18:49 pts/3    00:00:00 /snap/snapcraft/x14/usr/lib/apt/methods/store

and the pull finished successfully.

Since the introduction of patchelf, it is not necessary to compile apt
anymore, this brings in two important benefits:

- faster builds
- automatic USNs for CVEs where apt is affected

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@codecov-io
Copy link

codecov-io commented Jun 5, 2018

Codecov Report

Merging #2156 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2156      +/-   ##
==========================================
- Coverage   91.32%   91.31%   -0.01%     
==========================================
  Files         193      193              
  Lines       12168    12170       +2     
  Branches     1814     1814              
==========================================
+ Hits        11112    11113       +1     
- Misses        714      716       +2     
+ Partials      342      341       -1
Impacted Files Coverage Δ
snapcraft/internal/repo/_deb.py 75.93% <0%> (-0.48%) ⬇️
snapcraft/internal/elf.py 83.17% <0%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa9fdaf...465d3ad. Read the comment docs.

Copy link
Contributor

@kyrofa kyrofa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out, seems to work well!

@kyrofa kyrofa merged commit 4cbe8c1 into canonical:master Jun 7, 2018
xnox pushed a commit to xnox/snapcraft that referenced this pull request Jul 3, 2020
Since the introduction of patchelf, it is not necessary to compile apt
anymore, this brings in two important benefits:

- faster builds
- automatic USNs for CVEs where apt is affected

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants