Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs plugin: update to the latest 6.x LTS point release #2157

Merged

Conversation

sergiusens
Copy link
Collaborator

LP: #1772126
Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on bug reports?
  • If this is a new feature. Have you discussed the design on the forum?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh unit?

LP: #1772126
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@codecov-io
Copy link

Codecov Report

Merging #2157 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2157      +/-   ##
==========================================
+ Coverage   91.32%   91.32%   +<.01%     
==========================================
  Files         193      193              
  Lines       12168    12168              
  Branches     1814     1814              
==========================================
+ Hits        11112    11113       +1     
  Misses        714      714              
+ Partials      342      341       -1
Impacted Files Coverage Δ
snapcraft/plugins/nodejs.py 93.54% <100%> (ø) ⬆️
snapcraft/internal/elf.py 83.17% <0%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa9fdaf...7222764. Read the comment docs.

Copy link
Contributor

@kyrofa kyrofa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@sergiusens sergiusens merged commit 4b66366 into canonical:master Jun 6, 2018
@sergiusens sergiusens deleted the nodejs-default-latest-point-release branch June 6, 2018 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants