Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: new codespell, narrowed checks and better execution order #2162

Merged
merged 1 commit into from Jun 20, 2018

Conversation

sergiusens
Copy link
Collaborator

  • Run mypy first and only then do spell checking.
  • Update codespell to 0.12.0 which has better detection.
  • Fix spelling issues discovered by codespell.
  • Narrow down the list of directories searched for (no need to look in
    e.g.; parts).

Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on bug reports?
  • If this is a new feature. Have you discussed the design on the forum?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh unit?

…ests

- Run mypy first and only then do spell checking.
- Update codespell to 0.12.0 which has better detection.
- Fix spelling issues discovered by codespell.
- Narrow down the list of directories searched for (no need to look in
  e.g.; parts).

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Copy link
Contributor

@kyrofa kyrofa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you, I've had to fix some of these items locally as well, now I don't need to propose them.

@codecov-io
Copy link

codecov-io commented Jun 19, 2018

Codecov Report

Merging #2162 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2162      +/-   ##
==========================================
- Coverage   91.19%   91.18%   -0.01%     
==========================================
  Files         198      198              
  Lines       12471    12471              
  Branches     1846     1846              
==========================================
- Hits        11373    11372       -1     
  Misses        742      742              
- Partials      356      357       +1
Impacted Files Coverage Δ
snapcraft/internal/project_loader/_config.py 99.52% <ø> (ø) ⬆️
snapcraft/plugins/ruby.py 98.79% <ø> (ø) ⬆️
snapcraft/project/_project_options.py 89.23% <ø> (ø) ⬆️
snapcraft/plugins/kernel.py 94.11% <ø> (ø) ⬆️
...apcraft/internal/build_providers/_base_provider.py 100% <ø> (ø) ⬆️
snapcraft/internal/elf.py 82.84% <0%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44ae843...ef87d22. Read the comment docs.

@kyrofa kyrofa merged commit d16e21b into canonical:master Jun 20, 2018
@sergiusens sergiusens deleted the static-tests branch June 20, 2018 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants