build_providers: add ssh key managemet to the qemu build provider #2168
Conversation
sergiusens
changed the title
…ider LP: #1774013 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Codecov Report
@@ Coverage Diff @@
## master #2168 +/- ##
=========================================
+ Coverage 91.29% 91.3% +<.01%
=========================================
Files 200 201 +1
Lines 12580 12605 +25
Branches 1871 1872 +1
=========================================
+ Hits 11485 11509 +24
Misses 741 741
- Partials 354 355 +1
Continue to review full report at Codecov.
|
| SSHKeyT = TypeVar('SSHKeyT', bound='SSHKey') | ||
|
|
||
|
|
||
| class SSHKeyPathError(SnapcraftError): |
There was a problem hiding this comment.
This error class name could be more descriptive: it's not just a problem with the path (permissions etc.), it's that the path doesn't actually exist.
There was a problem hiding this comment.
Also, no strong feelings here, but I'm curious why this isn't in build_providers/errors.py?
There was a problem hiding this comment.
I had the feeling it was qemu specific, but after a check I see the telnet stuff made it there too.
| super().__init__(private_key_file_path=private_key_file_path) | ||
|
|
||
|
|
||
| class SSHKey: |
There was a problem hiding this comment.
Class and function docs would be nice.
There was a problem hiding this comment.
hmm, I wonder where they went, I did actually write them 😕
There was a problem hiding this comment.
reflog did not rescue me :-/
…ider
LP: #1774013
Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com
./runtests.sh static?./runtests.sh unit?