{catkin,python} plugin: support cleaning #2171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiusens
reviewed
Jun 26, 2018
| @@ -159,20 +171,20 @@ def _ensure_pip_installed(self): | |||
| if not self._is_pip_installed(): | |||
| logger.info('Fetching and installing pip...') | |||
|
|
|||
| real_python_home = self._python_home | |||
| real_python_home = self.__python_home | |||
There was a problem hiding this comment.
doesn't this have an extra _?
There was a problem hiding this comment.
Yeah it looks a tad off, but it maintains current behavior: "Ignore whatever you think you know, use this one. Okay, now you can go back to normal."
There was a problem hiding this comment.
Yeah, it is made clear in the comments below, but not as I read line by line until I reached the end of it 😄
Both the Catkin and Python plugins utilize the Pip class in order to clean their pull steps (specifically, they tell the Pip class to clean its packages). However, when cleaning the pull step, Python has already been removed from the installdir, which means the Pip class cannot be instantiated, causing an error about being unable to find Python. It's reasonable to ask Pip to clean any fetched packages, and doing so doesn't require Python. Fix this issue by lazily looking for Python only when it's required instead of upon class instantiation. LP: #1778716 Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
kyrofa
force-pushed
the
bugfix/1778716/clean_python_plugin
branch
from
0149284
to
b2a9dac
Compare
Codecov Report
@@ Coverage Diff @@
## master #2171 +/- ##
==========================================
+ Coverage 91.31% 91.32% +<.01%
==========================================
Files 201 201
Lines 12610 12617 +7
Branches 1872 1874 +2
==========================================
+ Hits 11515 11522 +7
Misses 741 741
Partials 354 354
Continue to review full report at Codecov.
|
sergiusens
approved these changes
Jun 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./runtests.sh static?./runtests.sh unit?Both the Catkin and Python plugins utilize the Pip class in order to clean their pull steps (specifically, they tell the Pip class to clean its packages). However, when cleaning the pull step, Python has already been removed from the installdir, which means the Pip class cannot be instantiated, causing an error about being unable to find Python.
It's reasonable to ask Pip to clean any fetched packages, and doing so doesn't require Python. This PR fixes LP: #1778716 by lazily looking for Python only when it's required instead of upon class instantiation.