cli: SNAPCRAFT_BUILD_ENVIRONMENT isn't deprecated #2179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SNAPCRAFT_CONTAINER_BUILDS is deprecated, but we have a confusing error message if both are provided, saying that SNAPCRAFT_BUILD_ENVIRONMENT is the one that's deprecated. Fix this to say that SNAPCRAFT_CONTAINER_BUILDS is the one that's deprecated. Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
Codecov Report
@@ Coverage Diff @@
## master #2179 +/- ##
==========================================
+ Coverage 91.22% 91.22% +<.01%
==========================================
Files 202 202
Lines 12848 12848
Branches 1906 1906
==========================================
+ Hits 11720 11721 +1
Misses 765 765
+ Partials 363 362 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./runtests.sh static?./runtests.sh unit?SNAPCRAFT_CONTAINER_BUILDS is deprecated, but we have a confusing error message if both are provided, saying that SNAPCRAFT_BUILD_ENVIRONMENT is the one that's deprecated. Fix this to say that SNAPCRAFT_CONTAINER_BUILDS is the one that's deprecated.