cli: reserve the --debug option for snapcraft projects #2185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiusens
force-pushed
the
debug-concerns
branch
2 times, most recently
from
976f523
to
f169259
Compare
Codecov Report
@@ Coverage Diff @@
## master #2185 +/- ##
==========================================
- Coverage 91.22% 91.21% -0.02%
==========================================
Files 202 202
Lines 12861 12865 +4
Branches 1907 1907
==========================================
+ Hits 11733 11735 +2
- Misses 766 768 +2
Partials 362 362
Continue to review full report at Codecov.
|
--debug has been conflated to debug snapcraft as a project itself and snapcraft projects users of snapcraft work on. For the former we introduce an environment variable to enable the existing debug logs statements in the snapcraft code base. LP: #1782772 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
sergiusens
force-pushed
the
debug-concerns
branch
from
f169259
to
9c210f2
Compare
kyrofa
approved these changes
Jul 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--debug has been conflated to debug snapcraft as a project itself and
snapcraft projects users of snapcraft work on. For the former we
introduce an environment variable to enable the existing debug logs
statements in the snapcraft code base.
LP: #1782772
Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com
./runtests.sh static?./runtests.sh unit?