Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python plugin: add process-dependency-links to the pull_properties #2190

Conversation

touilleMan
Copy link
Contributor

@touilleMan touilleMan commented Aug 3, 2018

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
    ==> Contributor form ask me for my Launchpad ID but I don't know how to get it (the link provided lead me to https://login.launchpad.net/ which show my personal details, but not this id...)
    ==> Contributor form also ask me for a "Project contact", no idea what to put there
  • If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on bug reports?
  • If this is a new feature. Have you discussed the design on the forum?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh unit?

Currently process-dependency-links option is not considered as a pull_properties i.e. build of this part won't be restarted if this option change. I guess this is not intended given this option do change the dependencies resolution.

@touilleMan touilleMan force-pushed the python-plugin_process-dependency-links_in_get_pull_properties branch from d655376 to 61514be Compare August 3, 2018 10:47
Copy link
Collaborator

@sergiusens sergiusens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the contribution.
I will ignore the CLA step as it is a one liner, but let me explain the launchpad id part for future PRs. Launchpad lives on launchpad.net, you can reach your home page provided that you are logged in by going to https://launchpad.net/~/
As an example, my launchpad home page is https://launchpad.net/~sergiusens and by going there you can see that the launchpad id is at the top left of the page (mine is sergiusens, which matches the ~ url as well).

@touilleMan
Copy link
Contributor Author

@sergiusens Thanks for the tip, I've signed the CLA now ;-)

@codecov-io
Copy link

codecov-io commented Aug 3, 2018

Codecov Report

Merging #2190 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2190      +/-   ##
==========================================
+ Coverage   91.22%   91.24%   +0.02%     
==========================================
  Files         201      201              
  Lines       12898    12898              
  Branches     1912     1912              
==========================================
+ Hits        11766    11769       +3     
+ Misses        768      767       -1     
+ Partials      364      362       -2
Impacted Files Coverage Δ
snapcraft/plugins/python.py 89.56% <100%> (ø) ⬆️
snapcraft/internal/elf.py 83.17% <0%> (+0.32%) ⬆️
snapcraft/internal/pluginhandler/_plugin_loader.py 93.75% <0%> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51518db...61514be. Read the comment docs.

@sergiusens sergiusens merged commit ff266dd into canonical:master Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants