Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop expecting the deprecation message in test. #2195

Merged
merged 1 commit into from Aug 7, 2018

Conversation

cprov
Copy link
Contributor

@cprov cprov commented Aug 7, 2018

Out of the blue we started getting this weird error in the 'Pre-merging' tests:

https://travis-ci.org/snapcore/snapcraft/builds/412858741

The proposed fix stop matching a chunk of opaque data before the revisions table. I suspect it was there for coping with the 'deprecation' message when the history command is used, but I can't tell for sure if anything related changed in snapcraft.

@codecov-io
Copy link

codecov-io commented Aug 7, 2018

Codecov Report

Merging #2195 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2195      +/-   ##
==========================================
- Coverage   91.22%   91.21%   -0.01%     
==========================================
  Files         201      201              
  Lines       12909    12909              
  Branches     1913     1913              
==========================================
- Hits        11776    11775       -1     
  Misses        770      770              
- Partials      363      364       +1
Impacted Files Coverage Δ
snapcraft/internal/elf.py 82.84% <0%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff266dd...903a6ed. Read the comment docs.

Copy link
Collaborator

@sergiusens sergiusens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry about this

@sergiusens sergiusens merged commit 3a41263 into canonical:master Aug 7, 2018
@cprov
Copy link
Contributor Author

cprov commented Aug 7, 2018

@sergiusens thanks for clarifying that it was not about the deprecation message (which does not affect the command in question, revisions is not deprecated). The opaque chunk of text was for the debug messages that are not disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants