Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add spread suite for copy plugin #2199

Merged

Conversation

kyrofa
Copy link
Contributor

@kyrofa kyrofa commented Aug 8, 2018

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on bug reports?
  • If this is a new feature. Have you discussed the design on the forum?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh unit?

This PR resolves LP: #1783831 by moving the integration tests for the copy plugin into a spread suite.

Move the integration tests for the copy plugin into a spread suite.

LP: #1783831

Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
@kyrofa kyrofa force-pushed the feature/1783831/copy_plugin_spread branch from c2d56ae to 3f11b44 Compare August 8, 2018 02:54
@codecov-io
Copy link

codecov-io commented Aug 8, 2018

Codecov Report

Merging #2199 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2199      +/-   ##
==========================================
+ Coverage   91.13%   91.15%   +0.02%     
==========================================
  Files         201      201              
  Lines       12920    12920              
  Branches     1915     1915              
==========================================
+ Hits        11774    11777       +3     
+ Misses        777      776       -1     
+ Partials      369      367       -2
Impacted Files Coverage Δ
snapcraft/internal/elf.py 83.17% <0%> (+0.32%) ⬆️
snapcraft/internal/pluginhandler/_plugin_loader.py 93.75% <0%> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f62504d...3f11b44. Read the comment docs.

@sergiusens sergiusens merged commit 41724d5 into canonical:master Aug 8, 2018
@kyrofa kyrofa deleted the feature/1783831/copy_plugin_spread branch August 8, 2018 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants