tests: add spread suite for godeps plugin #2200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2200 +/- ##
=========================================
- Coverage 91.18% 91.1% -0.08%
=========================================
Files 202 201 -1
Lines 12988 12924 -64
Branches 1922 1915 -7
=========================================
- Hits 11843 11775 -68
- Misses 777 780 +3
- Partials 368 369 +1
Continue to review full report at Codecov.
|
kyrofa
force-pushed
the
feature/1783833/godeps_plugin_spread
branch
from
a49331b
to
244ec19
Compare
Move the plugin integration tests for the Godeps plugin into a Spread suite. LP: #1783833 Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
kyrofa
force-pushed
the
feature/1783833/godeps_plugin_spread
branch
from
244ec19
to
54fc0a1
Compare
sergiusens
approved these changes
Aug 10, 2018
sergiusens
reviewed
Aug 10, 2018
| export GOPATH=/tmp/go | ||
| /snap/bin/go get -u github.com/snapcore/spread/cmd/spread | ||
|
|
||
| # Remove the go snap since we want to test (among other things) the Go plugin | ||
| sudo snap remove go |
There was a problem hiding this comment.
we will need to fix this later in a different form, but good call on uninstalling every unneeded bit to ensure we have a self sustainable system in place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./runtests.sh static?./runtests.sh unit?This PR resolves LP: #1783833 by moving the plugin integration tests for the Godeps plugin into a Spread suite.