Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add spread suite for nil plugin #2201

Merged

Conversation

kyrofa
Copy link
Contributor

@kyrofa kyrofa commented Aug 8, 2018

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on bug reports?
  • If this is a new feature. Have you discussed the design on the forum?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh unit?

This PR resolves LP: #1783838 by moving the plugin integration tests for the Nil plugin into a Spread suite.

kyrofa and others added 2 commits August 7, 2018 20:50
Move the plugin integration tests for the Nil plugin into a Spread
suite.

LP: #1783838

Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
@codecov-io
Copy link

codecov-io commented Aug 8, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@1af1ae5). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #2201   +/-   ##
========================================
  Coverage          ?   91.1%           
========================================
  Files             ?     201           
  Lines             ?   12924           
  Branches          ?    1915           
========================================
  Hits              ?   11775           
  Misses            ?     780           
  Partials          ?     369

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1af1ae5...c96caf3. Read the comment docs.

Copy link
Collaborator

@sergiusens sergiusens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so complex!

@sergiusens sergiusens merged commit 67d94bd into canonical:master Aug 8, 2018
@kyrofa kyrofa deleted the feature/1783838/nil_plugin_spread branch August 8, 2018 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants