Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add spread suite for kbuild plugin #2203

Merged

Conversation

kyrofa
Copy link
Contributor

@kyrofa kyrofa commented Aug 8, 2018

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on bug reports?
  • If this is a new feature. Have you discussed the design on the forum?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh unit?

This PR resolves LP: #1783835 by moving the plugin integration tests for the Kbuild plugin into a Spread suite.

Move the plugin integration tests for the Kbuild plugin into a Spread
suite.

LP: #1783835

Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
@kyrofa kyrofa force-pushed the feature/1783835/kbuild_plugin_spread branch from 6e74bd4 to fbf5db7 Compare August 8, 2018 21:04
@codecov-io
Copy link

codecov-io commented Aug 8, 2018

Codecov Report

Merging #2203 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2203      +/-   ##
==========================================
+ Coverage   91.17%   91.19%   +0.02%     
==========================================
  Files         202      202              
  Lines       12987    12987              
  Branches     1921     1921              
==========================================
+ Hits        11841    11844       +3     
+ Misses        777      776       -1     
+ Partials      369      367       -2
Impacted Files Coverage Δ
snapcraft/internal/elf.py 83.17% <0%> (+0.32%) ⬆️
snapcraft/internal/pluginhandler/_plugin_loader.py 93.75% <0%> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67d94bd...fbf5db7. Read the comment docs.

@sergiusens sergiusens merged commit f5d1b17 into canonical:master Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants