kbuild: stop modifying kconfigfile #2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the `kconfigfile` option is supplied, the kbuild plugin uses a hard link to put it into place. This becomes problematic if `kconfigfile` is used alongside `kconfigs`, because doing so modifies the config file, thereby modifying the original `kconfigfile` in the source tree. Fix this by copying the `kconfigfile` instead of using hard links. LP: #1786083 Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
Codecov Report
@@ Coverage Diff @@
## master #2204 +/- ##
=========================================
Coverage ? 91.12%
=========================================
Files ? 201
Lines ? 12924
Branches ? 1915
=========================================
Hits ? 11777
Misses ? 779
Partials ? 368
Continue to review full report at Codecov.
|
sergiusens
approved these changes
Aug 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./runtests.sh static?./runtests.sh unit?If the
kconfigfileoption is supplied, the kbuild plugin uses a hard link to put it into place. This becomes problematic ifkconfigfileis used alongsidekconfigs, because doing so modifies the config file, thereby modifying the originalkconfigfilein the source tree.This PR fixes LP: #1786083 by copying the
kconfigfileinstead of using hard links.