Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add spread suite for meson plugin #2205

Merged

Conversation

kyrofa
Copy link
Contributor

@kyrofa kyrofa commented Aug 8, 2018

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on bug reports?
  • If this is a new feature. Have you discussed the design on the forum?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh unit?

This PR resolves LP: #1783837 by moving the plugin integration tests for the Meson plugin into a Spread suite.

Copy link
Collaborator

@sergiusens sergiusens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meson is not available on trusty.

And I thought know how this creeped up again, but we had this issues before,
meson.build:2:0: ERROR: Target names starting with 'meson-' are reserved for Meson's internal use. Please rename.

Move the plugin integration tests for the Meson plugin into a Spread
suite.

LP: #1783837

Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
@kyrofa kyrofa force-pushed the feature/1783837/meson_plugin_spread branch from 3ec83f1 to 605fa3f Compare August 9, 2018 15:20
@codecov-io
Copy link

codecov-io commented Aug 9, 2018

Codecov Report

Merging #2205 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2205   +/-   ##
=======================================
  Coverage   91.18%   91.18%           
=======================================
  Files         202      202           
  Lines       12988    12988           
  Branches     1922     1922           
=======================================
  Hits        11843    11843           
  Misses        777      777           
  Partials      368      368

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10139a4...605fa3f. Read the comment docs.

@kyrofa
Copy link
Contributor Author

kyrofa commented Aug 9, 2018

meson is not available on trusty.

Ah very good. Fixed.

And I thought know how this creeped up again, but we had this issues before,
meson.build:2:0: ERROR: Target names starting with 'meson-' are reserved for Meson's internal use. Please rename.

My mistake, I've fixed it.

@kyrofa kyrofa merged commit 19c651a into canonical:master Aug 9, 2018
@kyrofa kyrofa deleted the feature/1783837/meson_plugin_spread branch August 9, 2018 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants