Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add spread suite for tar-content plugin #2209

Merged

Conversation

kyrofa
Copy link
Contributor

@kyrofa kyrofa commented Aug 9, 2018

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on bug reports?
  • If this is a new feature. Have you discussed the design on the forum?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh unit?

This PR resolves LP: #1783845 by moving the plugin integration tests for the tar-content plugin into a Spread suite.

Copy link
Collaborator

@sergiusens sergiusens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on just killing this moving forward btw?

@kyrofa kyrofa force-pushed the feature/1783845/tar_content_spread branch from dd5bacf to b695613 Compare August 10, 2018 22:37
@codecov-io
Copy link

codecov-io commented Aug 10, 2018

Codecov Report

Merging #2209 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2209      +/-   ##
=========================================
+ Coverage   91.19%   91.2%   +<.01%     
=========================================
  Files         202     202              
  Lines       12992   12992              
  Branches     1922    1922              
=========================================
+ Hits        11848   11849       +1     
  Misses        776     776              
+ Partials      368     367       -1
Impacted Files Coverage Δ
snapcraft/internal/elf.py 83.17% <0%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5498d0a...e2c9acf. Read the comment docs.

Move the plugin integration tests for the tar-content plugin into a
Spread suite.

LP: #1783845

Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
@kyrofa kyrofa force-pushed the feature/1783845/tar_content_spread branch from b695613 to e2c9acf Compare August 11, 2018 20:33
@sergiusens sergiusens merged commit 3810b91 into canonical:master Aug 13, 2018
@kyrofa kyrofa deleted the feature/1783845/tar_content_spread branch August 13, 2018 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants