Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add spread suite for waf plugin #2210

Merged
merged 1 commit into from Aug 11, 2018

Conversation

kyrofa
Copy link
Contributor

@kyrofa kyrofa commented Aug 9, 2018

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on bug reports?
  • If this is a new feature. Have you discussed the design on the forum?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh unit?

This PR resolves LP: #1783846 by moving the plugin integration tests for the Waf plugin into a Spread suite.

summary: test the waf plugin
description: |
This is a basic waf snap with configflags.
confinement: strict

apps:
waf-with-configflags:
waf-hello:
command: usr/local/bin/myprogram
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awe, you didn't change this to hello! :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't feel like actually learning Waf 😛 .

@codecov-io
Copy link

codecov-io commented Aug 10, 2018

Codecov Report

Merging #2210 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2210      +/-   ##
==========================================
- Coverage   91.19%   91.18%   -0.02%     
==========================================
  Files         202      202              
  Lines       12992    12988       -4     
  Branches     1922     1922              
==========================================
- Hits        11848    11843       -5     
- Misses        776      777       +1     
  Partials      368      368
Impacted Files Coverage Δ
snapcraft/internal/pluginhandler/_plugin_loader.py 91.96% <0%> (-1.79%) ⬇️
snapcraft/plugins/kernel.py 94.11% <0%> (-0.11%) ⬇️
snapcraft/internal/elf.py 83.17% <0%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b12e9c...60cd2c9. Read the comment docs.

Move the plugin integration tests for the Waf plugin into a Spread
suite.

LP: #1783846

Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
@kyrofa kyrofa force-pushed the feature/1783846/waf_plugin_spread branch from c0779ee to 60cd2c9 Compare August 10, 2018 22:35
@kyrofa kyrofa merged commit 5498d0a into canonical:master Aug 11, 2018
@kyrofa kyrofa deleted the feature/1783846/waf_plugin_spread branch August 11, 2018 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants