Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add spread suite for ament plugin #2211

Merged
merged 5 commits into from Aug 13, 2018

Conversation

kyrofa
Copy link
Contributor

@kyrofa kyrofa commented Aug 9, 2018

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on bug reports?
  • If this is a new feature. Have you discussed the design on the forum?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh unit?

This PR resolves LP: #1783827 by moving the snapd integration test for the Ament plugin into a Spread suite.

Move the snapd integration test for the Ament plugin into a Spread
suite.

LP: #1783827

Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
@kyrofa kyrofa force-pushed the feature/1783827/ament_plugin_spread branch from 2cadc24 to d134e10 Compare August 10, 2018 22:33
@codecov-io
Copy link

codecov-io commented Aug 10, 2018

Codecov Report

Merging #2211 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2211      +/-   ##
=========================================
- Coverage   91.21%   91.2%   -0.02%     
=========================================
  Files         208     208              
  Lines       13160   13160              
  Branches     1957    1957              
=========================================
- Hits        12004   12002       -2     
- Misses        788     789       +1     
- Partials      368     369       +1
Impacted Files Coverage Δ
snapcraft/internal/pluginhandler/_plugin_loader.py 91.96% <0%> (-1.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3810b91...c8ab7ad. Read the comment docs.

@kyrofa kyrofa merged commit bdaa8ea into canonical:master Aug 13, 2018
@kyrofa kyrofa deleted the feature/1783827/ament_plugin_spread branch August 13, 2018 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants