Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ci: disable osx tests until a new pyyaml is released" #2213

Merged
merged 5 commits into from Aug 15, 2018

Conversation

sergiusens
Copy link
Collaborator

pyyaml has been released and the brew formula has been updated.

This reverts commit 75c06e4.

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on bug reports?
  • If this is a new feature. Have you discussed the design on the forum?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

pyyaml has been released and the brew formula has been updated.

This reverts commit 75c06e4.
@codecov-io
Copy link

codecov-io commented Aug 14, 2018

Codecov Report

Merging #2213 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2213      +/-   ##
==========================================
- Coverage   91.21%   91.21%   -0.01%     
==========================================
  Files         208      210       +2     
  Lines       13160    13318     +158     
  Branches     1957     1982      +25     
==========================================
+ Hits        12004    12148     +144     
- Misses        788      795       +7     
- Partials      368      375       +7
Impacted Files Coverage Δ
snapcraft/internal/dirs.py 53.33% <0%> (-0.52%) ⬇️
snapcraft/internal/project_loader/_env.py 96.22% <0%> (ø) ⬆️
snapcraft/cli/templates.py 87.09% <0%> (ø)
snapcraft/internal/project_loader/_templates.py 91.17% <0%> (ø)
snapcraft/internal/project_loader/_config.py 99.52% <0%> (ø) ⬆️
snapcraft/cli/_runner.py 95.45% <0%> (+0.1%) ⬆️
snapcraft/internal/common.py 97.22% <0%> (+0.12%) ⬆️
snapcraft/internal/project_loader/__init__.py 92.3% <0%> (+0.3%) ⬆️
snapcraft/internal/project_loader/errors.py 96.15% <0%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b772997...4fc27e1. Read the comment docs.

@sergiusens
Copy link
Collaborator Author

Only seeing errors in spread which are unrelated

2018-08-15 11:23:33 Failed tasks: 6
    - google:ubuntu-14.04-64:tests/spread/plugins/autotools/cross_compile
    - google:ubuntu-14.04-64:tests/spread/plugins/autotools/run
    - google:ubuntu-16.04-64:tests/spread/plugins/autotools/cross_compile
    - google:ubuntu-16.04-64:tests/spread/plugins/autotools/run
    - google:ubuntu-18.04-64:tests/spread/plugins/autotools/cross_compile
    - google:ubuntu-18.04-64:tests/spread/plugins/autotools/run
error: unsuccessful run

@sergiusens sergiusens merged commit c3bf480 into canonical:master Aug 15, 2018
@sergiusens sergiusens deleted the reenable-osx branch August 15, 2018 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants