sentry: support disabling error reporting #2214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently regressed on canonical#2154 by removing the ability to disable Sentry, which can cause tests to hang. Add this ability back. Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
sergiusens
approved these changes
Aug 14, 2018
sergiusens
requested changes
Aug 14, 2018
| @@ -162,7 +162,7 @@ def setUp(self): | |||
| # Disable Sentry reporting for tests, otherwise they'll hang waiting | |||
| # for input | |||
| self.useFixture( | |||
| fixtures.EnvironmentVariable("SNAPCRAFT_ENABLE_SENTRY", "false") | |||
| fixtures.EnvironmentVariable("SNAPCRAFT_ENABLE_ERROR_REPORTING", "false") | |||
There was a problem hiding this comment.
oh, the new structure makes this unnecessary, to be honest, I'd remove these lines completely
sergiusens
approved these changes
Aug 15, 2018
Codecov Report
@@ Coverage Diff @@
## master #2214 +/- ##
==========================================
+ Coverage 91.15% 91.16% +<.01%
==========================================
Files 211 211
Lines 13460 13462 +2
Branches 2006 2007 +1
==========================================
+ Hits 12270 12272 +2
Misses 808 808
Partials 382 382
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./runtests.sh static?./runtests.sh tests/unit?We recently regressed on #2154 by removing the ability to disable Sentry, which can cause tests to hang. Add this ability back.