Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider changes #2215

Merged
merged 1 commit into from Aug 16, 2018
Merged

provider changes #2215

merged 1 commit into from Aug 16, 2018

Conversation

sergiusens
Copy link
Collaborator

Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on bug reports?
  • If this is a new feature. Have you discussed the design on the forum?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Copy link
Contributor

@kyrofa kyrofa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, makes sense.

@codecov-io
Copy link

Codecov Report

Merging #2215 into master will decrease coverage by 0.01%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2215      +/-   ##
==========================================
- Coverage   91.15%   91.14%   -0.02%     
==========================================
  Files         211      211              
  Lines       13460    13464       +4     
  Branches     2006     2007       +1     
==========================================
+ Hits        12270    12272       +2     
  Misses        808      808              
- Partials      382      384       +2
Impacted Files Coverage Δ
snapcraft/cli/lifecycle.py 92.04% <60%> (-2.01%) ⬇️
snapcraft/plugins/jhbuild.py 41.66% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3bf480...9c2c4ec. Read the comment docs.

@sergiusens sergiusens merged commit 7a52208 into canonical:master Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants