tests: use SNAPCRAFT_PACKAGE_TYPE everywhere #2295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retire the use of SNAPCRAFT_FROM_ environment variables to smooth the transition of these legacy tests into spread. Also remove the unused container tests. LP: #1794379 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
sergiusens
force-pushed
the
tests-vars
branch
from
0e94e96
to
44fcc85
Compare
kyrofa
reviewed
Sep 26, 2018
| @@ -1,43 +0,0 @@ | |||
| # -*- Mode:Python; indent-tabs-mode:nil; tab-width:4 -*- | |||
There was a problem hiding this comment.
This seems unrelated to this PR.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
kyrofa
approved these changes
Sep 26, 2018
Codecov Report
@@ Coverage Diff @@
## master #2295 +/- ##
=======================================
Coverage 90.56% 90.56%
=======================================
Files 216 216
Lines 13806 13806
Branches 2046 2046
=======================================
Hits 12503 12503
Misses 897 897
Partials 406 406Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retire the use of SNAPCRAFT_FROM_ environment variables to smooth
the transition of these legacy tests into spread.
Also remove the unused container tests.
LP: #1794379
Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com
./runtests.sh static?./runtests.sh tests/unit?