storeapi: Use structured data for the conflicted current value #2316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of relying on the Store's value being in the mssage of the error use the structured data found in 'extra' instead. Also updated the fake store to match reality.
|
@facundobatista @matiasb since you guys worked on the original code, do you mind taking a quick peek at this? |
sergiusens
approved these changes
Oct 4, 2018
sergiusens
pushed a commit
to sergiusens/snapcraft
that referenced
this pull request
Oct 4, 2018
…ical#2316) Instead of relying on the Store's value being in the message of the error use the structured data found in 'extra' instead. Also updated the fake store to match reality. LP: #1795416
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./runtests.sh static?./runtests.sh tests/unit?Part of the fix for lp:1795416 when there's a conflict with the metadata, snapcraft should use the structured data coming from the conflict error in the store, instead of the message.
The fake store here is updated to the WiP branch I have for the store, which will remove the user supplied values from the error's message.