Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: remove disable-parallel-build and geoip toggles #2377

Merged
merged 3 commits into from Oct 20, 2018

Conversation

sergiusens
Copy link
Collaborator

These are not useful with bases.

LP: #1798925

Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on bug reports?
  • If this is a new feature. Have you discussed the design on the forum?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

These are not useful with bases.

LP: #1798925

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@57c7fb8). Click here to learn what that means.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2377   +/-   ##
=========================================
  Coverage          ?   90.26%           
=========================================
  Files             ?      195           
  Lines             ?    12746           
  Branches          ?     1926           
=========================================
  Hits              ?    11505           
  Misses            ?      843           
  Partials          ?      398
Impacted Files Coverage Δ
snapcraft/cli/_options.py 85.18% <ø> (ø)
snapcraft/internal/repo/_deb.py 73.61% <100%> (ø)
snapcraft/project/_project.py 100% <100%> (ø)
snapcraft/project/_project_options.py 86.42% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57c7fb8...b89b28d. Read the comment docs.

@sergiusens sergiusens merged commit f6ed44e into canonical:master Oct 20, 2018
@sergiusens sergiusens deleted the build-options branch October 20, 2018 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants