Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: handle symlinked hooks (#2478) #2481

Merged
merged 2 commits into from Feb 25, 2019

Conversation

sergiusens
Copy link
Collaborator

Handling of symlinked hooks broke with the introduction of #2440
which tries to change permissions of their file type which can
lead to FileNotFoundErrors as the symlinked file may not be
available at the time of the stat change.

Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on bug reports?
  • If this is a new feature. Have you discussed the design on the forum?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

Handling of symlinked hooks broke with the introduction of canonical#2440
which tries to change permissions of their file type which can
lead to FileNotFoundErrors as the symlinked file may not be
available at the time of the stat change.

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Copy link
Contributor

@sparkiegeek sparkiegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-io
Copy link

codecov-io commented Feb 25, 2019

Codecov Report

❗ No coverage uploaded for pull request base (legacy@8f66a4e). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             legacy    #2481   +/-   ##
=========================================
  Coverage          ?   90.66%           
=========================================
  Files             ?      216           
  Lines             ?    13780           
  Branches          ?     2047           
=========================================
  Hits              ?    12494           
  Misses            ?      883           
  Partials          ?      403
Impacted Files Coverage Δ
snapcraft/internal/meta/_snap_packaging.py 90.36% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f66a4e...2c34d84. Read the comment docs.

@sergiusens sergiusens merged commit a9375a5 into canonical:legacy Feb 25, 2019
@sergiusens sergiusens deleted the legacy-symlinked-hooks branch February 25, 2019 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants