project loader: remove special LD_LIBRARY_FLAGS handling for classic #2484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiusens
force-pushed
the
legacy-classic-env
branch
from
1a0a534
to
0525323
Compare
Codecov Report
@@ Coverage Diff @@
## legacy #2484 +/- ##
=========================================
Coverage ? 90.66%
=========================================
Files ? 216
Lines ? 13780
Branches ? 2047
=========================================
Hits ? 12493
Misses ? 884
Partials ? 403
Continue to review full report at Codecov.
|
sergiusens
force-pushed
the
legacy-classic-env
branch
2 times, most recently
from
00deba8
to
1f069e5
Compare
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
sergiusens
force-pushed
the
legacy-classic-env
branch
2 times, most recently
from
62d686c
to
9057c79
Compare
This implementation can cause clashes with changes in the host with regards to the base in use (i.e; core, core18, ...) as their might be libc6 mismatches at the time that can lead to undefined behavior. The issue comes up when the core snap is installed as it is when the libraries are used, this specific behavior is no longer needed as the library crawling feature has improved since this was first introduced. Additionally, the Travis CI job has been moved to using the deb for the time being to overcome the bootstrapping issue that this misbehavior creates. This fix also has to be introduced into the legacy branch first as snapcraft uses the legacy implementation to build itself. LP: #1817300 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
sergiusens
force-pushed
the
legacy-classic-env
branch
from
9057c79
to
ca72458
Compare
chipaca
approved these changes
Feb 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation can cause clashes with changes in the host with
regards to the base in use (i.e; core, core18, ...) as their might
be libc6 mismatches at the time that can lead to undefined behavior.
The issue comes up when the core snap is installed as it is when
the libraries are used, this specific behavior is no longer needed
as the library crawling feature has improved since this was first
introduced.
Additionally, the Travis CI job has been moved to using the deb
for the time being to overcome the bootstrapping issue that this
misbehavior creates.
This fix also has to come into legacy first to as snapcraft builds with
legacy be
LP: #1817300
Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com
./runtests.sh static?./runtests.sh tests/unit?