cli: disable raven if not running from package #2503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to avoid bogus environment misconfiguration reports, only allow Sentry submissions if running from the packaged distribution. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
sergiusens
reviewed
Mar 15, 2019
Codecov Report
@@ Coverage Diff @@
## master #2503 +/- ##
=========================================
Coverage ? 89.93%
=========================================
Files ? 198
Lines ? 13358
Branches ? 2021
=========================================
Hits ? 12013
Misses ? 921
Partials ? 424
Continue to review full report at Codecov.
|
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
cmatsuoka
force-pushed
the
sentry-only-from-package
branch
from
6be794f
to
fca03f8
Compare
sergiusens
approved these changes
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to avoid bogus environment misconfiguration reports, only allow
Sentry submissions if running from the packaged distribution.
Signed-off-by: Claudio Matsuoka claudio.matsuoka@canonical.com
./runtests.sh static?./runtests.sh tests/unit?