Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -h short option for help #2527

Merged
merged 1 commit into from Jul 1, 2019
Merged

Conversation

techtonik
Copy link
Contributor

@techtonik techtonik commented Apr 9, 2019

Fixes https://bugs.launchpad.net/snapcraft/+bug/1807423

https://click.palletsprojects.com/en/7.x/documentation/#help-parameter-customization

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

@sergiusens
Copy link
Collaborator

Hi there, have you indeed signed the CLA, the tests says no but you marked the checkbox

Copy link
Contributor

@cjp256 cjp256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refreshed and CLA check passed.

@codecov-io
Copy link

codecov-io commented Jun 26, 2019

Codecov Report

Merging #2527 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2527      +/-   ##
==========================================
- Coverage   89.13%   89.08%   -0.05%     
==========================================
  Files         208      207       -1     
  Lines       14201    14094     -107     
  Branches     2152     2131      -21     
==========================================
- Hits        12658    12556     -102     
+ Misses       1091     1086       -5     
  Partials      452      452
Impacted Files Coverage Δ
snapcraft/cli/_runner.py 91.83% <100%> (ø) ⬆️
snapcraft/plugins/ant.py 86.61% <0%> (-2.28%) ⬇️
snapcraft/internal/pluginhandler/_plugin_loader.py 83.33% <0%> (-1.97%) ⬇️
snapcraft/plugins/rust.py 94.44% <0%> (-0.89%) ⬇️
snapcraft/cli/ci.py 86.66% <0%> (-0.84%) ⬇️
snapcraft/internal/elf.py 80.71% <0%> (-0.36%) ⬇️
snapcraft/internal/sources/_script.py 100% <0%> (ø) ⬆️
snapcraft/plugins/conda.py
snapcraft/cli/lifecycle.py 86.95% <0%> (+0.09%) ⬆️
snapcraft/cli/_options.py 89.47% <0%> (+7.25%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e00b690...ea7a4a6. Read the comment docs.

@techtonik
Copy link
Contributor Author

Rebased and squashed black fixes.

@techtonik
Copy link
Contributor Author

spread test times out. No idea what does it do.

@sergiusens sergiusens merged commit a7ab97e into canonical:master Jul 1, 2019
@techtonik techtonik deleted the patch-1 branch July 2, 2019 10:11
@techtonik
Copy link
Contributor Author

@sergiusens thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants