Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build providers: get rid of attribute warnings from pylxd #2535

Merged
merged 1 commit into from
Apr 16, 2019

Conversation

sergiusens
Copy link
Collaborator

Filter out this specific warning, and potentially others coming from
pylxd.models.operation which are irrelevant to the end user:

/snap/snapcraft/2839/lib/python3.5/site-packages/pylxd/models/operation.py:59: UserWarning: Attempted to set unknown attribute "location" on instance of "Operation"
.format(key, self.class.name))

Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

Filter out this specific warning, and potentially others coming from
pylxd.models.operation which are irrelevant to the end user:

/snap/snapcraft/2839/lib/python3.5/site-packages/pylxd/models/operation.py:59: UserWarning: Attempted to set unknown attribute "location" on instance of "Operation"
  .format(key, self.__class__.__name__))

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@codecov-io
Copy link

Codecov Report

Merging #2535 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2535      +/-   ##
==========================================
- Coverage    89.1%   89.09%   -0.02%     
==========================================
  Files         201      201              
  Lines       13658    13660       +2     
  Branches     2068     2068              
==========================================
  Hits        12170    12170              
- Misses       1050     1051       +1     
- Partials      438      439       +1
Impacted Files Coverage Δ
snapcraft/internal/build_providers/_lxd/_lxd.py 24.27% <100%> (+0.88%) ⬆️
snapcraft/internal/pluginhandler/_plugin_loader.py 82.65% <0%> (-2.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 029e2d0...043f4bf. Read the comment docs.

@sergiusens sergiusens merged commit e5fc29a into canonical:master Apr 16, 2019
@sergiusens sergiusens deleted the pylxd-warnings branch April 16, 2019 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants