cli: snapcraft promote

[sergiusens]

Create a snap Status/Status class to easily handle the state response
and construct a channel set to use with the promote command.

LP: #1827513
Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com

• Have you followed the guidelines for contributing?
• Have you signed the CLA?
• Have you successfully run ./runtests.sh static?
• Have you successfully run ./runtests.sh tests/unit?

---

[codecov-io]

Codecov Report

Merging #2556 into master will increase coverage by 0.12%.
The diff coverage is 93.1%.

@@            Coverage Diff             @@
##           master    #2556      +/-   ##
==========================================
+ Coverage   88.85%   88.98%   +0.12%     
==========================================
  Files         202      204       +2     
  Lines       13794    13941     +147     
  Branches     2088     2108      +20     
==========================================
+ Hits        12257    12405     +148     
+ Misses       1093     1091       -2     
- Partials      444      445       +1

Impacted Files	Coverage Δ
snapcraft/storeapi/__init__.py	100% <100%> (ø)	⬆️
snapcraft/cli/_command_group.py	96.42% <100%> (+0.13%)	⬆️
snapcraft/storeapi/errors.py	85.67% <100%> (+0.43%)	⬆️
snapcraft/internal/build_providers/_snap.py	96.27% <100%> (+6.18%)	⬆️
snapcraft/cli/store.py	89.22% <90.9%> (+0.33%)	⬆️
snapcraft/storeapi/channels.py	92.3% <92.3%> (ø)
snapcraft/storeapi/status.py	93.15% <93.15%> (ø)
snapcraft/internal/elf.py	80.71% <0%> (-0.36%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c541fac...8206f99. Read the comment docs.

[cprov]

Thanks @sergiusens, the implementation looks good and easy to update to the actual promote endpoint when it exists in the store. Meanwhile, there is a remote possibility of revisions being partially promoted (if an attempt fails), running the same promotion command will fix it.

[cmatsuoka]

This is a very nice, elegantly coded and almost spotless implementation. Just added a few nitpicking comments about type annotations.

[sergiusens]

Thanks @cprov wrt promotion being individual releases, we do indeed suffer from this possibily, just like on the web interface, although it is easier to surface on a GUI than on a CLI

Thanks for the compliments @cmatsuoka, I will get to the type annotations.

[kyrofa]

What's up with this limitation? Bites me all the time. Why can't we promote from edge? It's documented right above as being valid, and we have a CI system that ONLY lands stuff in edge. Am I missing something?

[sergiusens]

I had a conversation and it is going away

…

On Sun, Jun 14, 2020 at 8:45 PM Kyle Fazzari ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In snapcraft/cli/store.py <#2556 (comment)>: > + elif parsed_from_channel.risk == "edge" and parsed_from_channel.branch is None: + raise click.BadOptionUsage( + "{!r} is not a valid set value for --from-channel.".format( + parsed_from_channel + ) + ) What's up with this limitation? Bites me all the time. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#2556 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIX7ZNSQW6S52Y4HJSZXLLRWVOKPANCNFSM4HLD6TBA> .