Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust plugin to be able to rebuild #2620

Merged
merged 4 commits into from Jul 10, 2019

Conversation

ChrisMacNaughton
Copy link
Contributor

@ChrisMacNaughton ChrisMacNaughton commented Jul 3, 2019

Currently, when a user re-runs snapcraft against a Rust project, the compiler refuses to "re"-install the package, and crashes the build. This change adds the --force flag to the install command which tells the rust compiler to re-install the package. This does not break the cargo compiler cache.

This PR resolves LP: #1825858

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

@sergiusens
Copy link
Collaborator

Hi, thanks for this, do you think you could create a new spread test, maybe tests/spread/plugins/rust/rebuild ?

Or if you do not mind, I can do it as well.

@codecov-io
Copy link

codecov-io commented Jul 5, 2019

Codecov Report

Merging #2620 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2620   +/-   ##
=======================================
  Coverage   89.12%   89.12%           
=======================================
  Files         208      208           
  Lines       14207    14207           
  Branches     2157     2157           
=======================================
  Hits        12662    12662           
  Misses       1091     1091           
  Partials      454      454
Impacted Files Coverage Δ
snapcraft/plugins/rust.py 95.33% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 665143c...7491d8b. Read the comment docs.

Copy link
Collaborator

@sergiusens sergiusens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sergiusens sergiusens merged commit 601bd2d into canonical:master Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants