lifecycle: only warn when a default provider snap is missing #2885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snapcraft gained the ability to check for artifacts from snaps listed as plugs when using the content interface. The side effect, is that the snap needs to be published on the main Snap Store, this is a requirement brand stores cannot meet, so instead of failing, Snapcraft resorts to warning instead. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
flexiondotorg
approved these changes
Jan 19, 2020
fix in next commit
cjp256
reviewed
Jan 19, 2020
| installed_snaps += repo.snaps.install_snaps([content_snap]) | ||
| except repo.snaps.errors.SnapUnavailableError: | ||
| logger.warning( | ||
| f"Could not install snap defined in a plug {content_snap!r}. " |
| logger.warning( | ||
| f"Could not install snap defined in a plug {content_snap!r}. " | ||
| "The missing library report may have false positives listed if those " | ||
| "libraries were to be provided by the content snap." |
sergiusens
added a commit
to sergiusens/snapcraft
that referenced
this pull request
Jan 20, 2020
…al#2885) Snapcraft gained the ability to check for artifacts from snaps listed as plugs when using the content interface. The side effect, is that the snap needs to be published on the main Snap Store, this is a requirement brand stores cannot meet, so instead of failing, Snapcraft resorts to warning instead. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
sergiusens
added a commit
that referenced
this pull request
Jan 20, 2020
Snapcraft gained the ability to check for artifacts from snaps listed as plugs when using the content interface. The side effect, is that the snap needs to be published on the main Snap Store, this is a requirement brand stores cannot meet, so instead of failing, Snapcraft resorts to warning instead. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snapcraft gained the ability to check for artifacts from snaps listed as plugs
when using the content interface.
The side effect, is that the snap needs to be published on the main Snap Store,
this is a requirement brand stores cannot meet, so instead of failing,
Snapcraft resorts to warning instead.
Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com
./runtests.sh static?./runtests.sh tests/unit?