Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements: Update PyYAML requirement to 5.3 #2923

Merged
merged 2 commits into from
Feb 20, 2020

Conversation

NickZ
Copy link

@NickZ NickZ commented Feb 9, 2020

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

They are no longer providing updated wheels for windows for newer python versions (>3.7). This updates snapcraft to use 5.3 instead, which is the current version and is being provided updated wheels for newer python versions.

They are no longer providing updated wheels for windows for newer python versions (>3.7). This updates snapcraft to use 5.3 instead, which is the current version and is being provided updated wheels for newer python versions.
cjp256
cjp256 previously approved these changes Feb 10, 2020
@cjp256
Copy link
Contributor

cjp256 commented Feb 12, 2020

I did some testing and i don't think you need to point to the wheels.

PyYAML==5.3 worked just fine for me with Windows and python3.8.

@NickZ
Copy link
Author

NickZ commented Feb 12, 2020

It installs, yes, but I had previously gotten errors when using snapcraft with the version being installed from pip complaining that it wasn't compiled with libyaml bindings; was that not the case for you?

@cjp256
Copy link
Contributor

cjp256 commented Feb 12, 2020

It installs, yes, but I had previously gotten errors when using snapcraft with the version being installed from pip complaining that it wasn't compiled with libyaml bindings; was that not the case for you?

I think snapcraft raised a RuntimeError of that sort when I accidentally installed the old version that way (or something like that, I'm pretty sure I noted the old version at the time?). I can try it again.

@cjp256
Copy link
Contributor

cjp256 commented Feb 13, 2020

FWIW In my virtualenv I uninstalled pyyaml (re-)installed. Then re-built the subedit snap OK.

@NickZ
Copy link
Author

NickZ commented Feb 13, 2020 via email

@sergiusens sergiusens merged commit fdc0e78 into canonical:master Feb 20, 2020
@NickZ NickZ deleted the update-pyyaml branch February 29, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants