Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build providers: remove use of cloud-init #2940

Merged
merged 1 commit into from
Feb 21, 2020
Merged

Conversation

sergiusens
Copy link
Collaborator

Make use of other build provider functionality to have the necessary
assets on the build environment (i.e.; ._run and ._push_file).

The initial "first run" setup has been moved to its own method.

Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

Make use of other build provider functionality to have the necessary
assets on the build environment (i.e.; ._run and ._push_file).

The initial "first run" setup has been moved to its own method.

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@codecov-io
Copy link

Codecov Report

Merging #2940 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2940      +/-   ##
==========================================
+ Coverage   88.13%   88.16%   +0.03%     
==========================================
  Files         229      229              
  Lines       16565    16568       +3     
  Branches     2554     2554              
==========================================
+ Hits        14600    14608       +8     
+ Misses       1426     1422       -4     
+ Partials      539      538       -1
Impacted Files Coverage Δ
snapcraft/internal/build_providers/_lxd/_lxd.py 21.92% <ø> (-0.3%) ⬇️
.../internal/build_providers/_multipass/_multipass.py 84.61% <ø> (+1.56%) ⬆️
...apcraft/internal/build_providers/_base_provider.py 84.84% <100%> (+1.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fdd243...524870a. Read the comment docs.

@cjp256
Copy link
Contributor

cjp256 commented Feb 21, 2020

LGTM

@sergiusens sergiusens merged commit 9daee0b into master Feb 21, 2020
@sergiusens sergiusens deleted the snapcraft-init branch February 21, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants