meta: Snap to_dict() cleanup #2950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 19, 2020 20:23
Similar to that done for from_dict(), get rid of __dict__ usage in to_dict() and handle each field directly. More verbose, but detailed and more flexible. Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
When creating a dictionary, output all properties. Move the necessary transforms into write_snap_yaml(), in particular: - applying passthrough property - stripping adopt-info Clean up and add test coverage for both cases. Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
sergiusens
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__dict__usage and detail each property