meta: remove remaining __dict__ and key list usage in snap
#2953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 25, 2020 21:15
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
Remove _MANDATORY_PACKAGE_KEYS and _OPTIONAL_PACKAGE_KEYS as they are no longer used. Remove reference in comment found in unit tests as well. Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
cjp256
force-pushed
the
snap-dict-lists
branch
from
6591061
to
4f11ae5
Compare
sergiusens
approved these changes
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fix a c901 label for python 3.8 while I'm in the vicinity.