go plugin: do not remove install /bin directory before build #2957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Packages configured in a part's stage-packages are installed prior to build and installed to $SNAPCRAFT_PART_INSTALL. Cleaning $SNAPCRAFT_PART_INSTALL/bin will purge any files that may have been installed there. Running go build should overwrite any previously installed files, which will be OK for incremental builds. However, as the go plugin does not enable out_of_source_build, the entire build directory is purged on every build anyways. Add spread test for coverage. Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
|
LGTM |
sergiusens
requested changes
Mar 3, 2020
sergiusens
previously approved these changes
Mar 4, 2020
sergiusens
reviewed
Mar 4, 2020
tests/spread/plugins/go/snaps/go-use-stage-packages/go-hello/main.go
Outdated
Show resolved
Hide resolved
sergiusens
approved these changes
Mar 4, 2020
Codecov Report
@@ Coverage Diff @@
## master #2957 +/- ##
=========================================
Coverage ? 88.17%
=========================================
Files ? 229
Lines ? 16569
Branches ? 2560
=========================================
Hits ? 14610
Misses ? 1425
Partials ? 534
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages configured in a part's stage-packages are installed prior
to build and installed to $SNAPCRAFT_PART_INSTALL. Cleaning
$SNAPCRAFT_PART_INSTALL/bin will purge any files that may have been
installed there.
Running go build should overwrite any previously installed files,
which will be OK for incremental builds. However, as the go plugin
does not enable out_of_source_build, the entire build directory is
purged on every build anyways.
Add spread test for coverage.
Signed-off-by: Chris Patterson chris.patterson@canonical.com
Reported by @stgraber