project_loader: use -isystem instead of -I for system include paths #2974
+16
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warnings are ignored for sytem includes. However, when a system include gets installed to staging directory, the user may be issued warnings (errors if -Werror) because snapcraft is adding include paths thats include these system headers. Use `-isystem` rather than `-I` to add system include paths to the default compiler flags. The other option is to use `-idirafter`, but is more likely to affect current builds by changing the order of the search paths. For example: ``` In file included from /root/parts/workspace/install/usr/include/x86_64-linux-gnu/bits/fcntl.h:61:0, from /root/parts/workspace/install/usr/include/fcntl.h:35, from /root/parts/workspace/build/benchmark_catkin/benchmark_src-prefix/src/benchmark_src/src/sysinfo.cc:23: /root/parts/workspace/install/usr/include/x86_64-linux-gnu/bits/fcntl-linux.h:355:27: error: ISO C++ forbids zero-size array ‘f_handle’ [-Wpedantic] unsigned char f_handle[0]; ``` See: [1] https://gcc.gnu.org/onlinedocs/cpp/System-Headers.html > The header files declaring interfaces to the operating system and runtime libraries often cannot be written in strictly conforming C. Therefore, GCC gives code found in system headers special treatment. All warnings, other than those generated by ‘#warning’ (see Diagnostics), are suppressed while GCC is processing a system header. [2] https://gcc.gnu.org/onlinedocs/gcc/Directory-Options.html > The -isystem and -idirafter options also mark the directory as a system directory, so that it gets the same special treatment that is applied to the standard system directories. Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
Codecov Report
@@ Coverage Diff @@
## master #2974 +/- ##
=======================================
Coverage 88.17% 88.17%
=======================================
Files 229 229
Lines 16575 16575
Branches 2559 2559
=======================================
Hits 14615 14615
Misses 1424 1424
Partials 536 536
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
project_loader: use -isystem instead of -I for system include paths
Warnings are ignored for sytem includes. However, when a system
include gets installed to staging directory, the user may be
issued warnings (errors if -Werror) because snapcraft is adding
include paths thats include these system headers.
Use
-isystemrather than-Ito add system include paths tothe default compiler flags. The other option is to use
-idirafter,but is more likely to affect current builds by changing the order
of the search paths.
For example:
See:
[1] https://gcc.gnu.org/onlinedocs/cpp/System-Headers.html
[2] https://gcc.gnu.org/onlinedocs/gcc/Directory-Options.html
Signed-off-by: Chris Patterson chris.patterson@canonical.com
./runtests.sh static?./runtests.sh tests/unit?