Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specifications: experimental features guidelines #2975

Merged
merged 2 commits into from
Mar 16, 2020

Conversation

sergiusens
Copy link
Collaborator

Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>

This document defines a common pattern to follow to enable features that must be
disabled by default.
* Guidelines
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it renders fine, can you [set your editor to] include empty line breaks between empty sections? Just makes the raw text more readable without having a proper viewer. :-)

cjp256
cjp256 previously approved these changes Mar 16, 2020
@cjp256
Copy link
Contributor

cjp256 commented Mar 16, 2020

LGTM

@sergiusens sergiusens merged commit 9c6d1cc into canonical:master Mar 16, 2020
@sergiusens sergiusens deleted the experimental-flags branch March 16, 2020 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants