repo: always use host release and arch for Ubuntu #3006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove dependency of ProjectOptions parameter. - Update format_sources_list() tp query release arch/release separately. Update tests accordingly. Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
sergiusens
previously approved these changes
Apr 1, 2020
snapcraft/internal/repo/_deb.py
Outdated
| def _format_sources_list(sources_list: str, *, deb_arch: str, release: str = "xenial"): | ||
| def _format_sources_list(sources_list: str): | ||
| release = os_release.OsRelease().version_codename() | ||
| deb_arch = snapcraft.ProjectOptions().deb_arch |
There was a problem hiding this comment.
I wonder if this can go away completely.
There was a problem hiding this comment.
done, i ditched $suffix and $prefix. I was originally going to wait on that, but it's here now. :D
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
sergiusens
previously approved these changes
Apr 2, 2020
|
btw, you have format issues |
|
Fixed |
sergiusens
approved these changes
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove dependency of ProjectOptions parameter.
Update format_sources_list() tp query release arch/release
separately.
Update tests accordingly.
Signed-off-by: Chris Patterson chris.patterson@canonical.com
./runtests.sh static?./runtests.sh tests/unit?