go: support projects with multiple binaries when using go.mod #3007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a check to assert only one binary was built. - Remove the error check. If no binaries are found, warn. - Update logic to handle relinking multiple binaries. - Update multiple main spread test to also build with go.mod. Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
sergiusens
approved these changes
Apr 1, 2020
Codecov Report
@@ Coverage Diff @@
## master #3007 +/- ##
=======================================
Coverage 88.30% 88.30%
=======================================
Files 232 232
Lines 16576 16577 +1
Branches 2555 2556 +1
=======================================
+ Hits 14638 14639 +1
Misses 1401 1401
Partials 537 537
Continue to review full report at Codecov.
|
|
Store timeouts are unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a check to assert only one binary was built.
Remove the error check. If no binaries are found, warn.
Update logic to handle relinking multiple binaries.
Update multiple main spread test to also build with go.mod.
Signed-off-by: Chris Patterson chris.patterson@canonical.com
./runtests.sh static?./runtests.sh tests/unit?