plugins: introduce v2.PluginV2 and v2.NilPlugin #3022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rely less on setting from the plugin and remove duplicate attributes already held by Project and Project._snap_meta. This involved a general cleanup. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
There's just enough scaffolding in place to allow for the plugin to load. PluginHandler has been extended to determine when a PluginV2 is being used (PluginHandler should be renamed to PartHandler). Some extra attribute were added to PluginV2 to minimize the changes required in PluginHandler. Old code handling state file migration in PluginHandler._do_build was removed as that was done before the migration to bases (meaning that no base using Snapcraft project needs this). Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
|
@cjp256 yeah, fixed them earlier, my push got stuck on my ssh keys... |
cjp256
reviewed
Apr 9, 2020
| isinstance(self.plugin, plugins.v1.PluginV1) | ||
| and self.plugin.out_of_source_build | ||
| ): | ||
| if os.path.exists(self.part_build_dir): |
There was a problem hiding this comment.
so this will always happen with v2?
There was a problem hiding this comment.
I suppose this is what we just discussed not doing and you were going to look into. I can remove the rm entirely and we can see what happens
There was a problem hiding this comment.
i thought we discussed the opposite. v2 would leave the build directory alone and incremental builds would work?
There was a problem hiding this comment.
exactly, but I did this before that conversation, that's all I am saying :-)
There was a problem hiding this comment.
I say let's make the change now :)
cjp256
reviewed
Apr 9, 2020
cjp256
reviewed
Apr 9, 2020
cjp256
reviewed
Apr 9, 2020
cjp256
previously approved these changes
Apr 10, 2020
cjp256
suggested changes
Apr 10, 2020
| isinstance(self.plugin, plugins.v1.PluginV1) | ||
| and self.plugin.out_of_source_build | ||
| ): | ||
| if os.path.exists(self.part_build_dir): |
There was a problem hiding this comment.
I say let's make the change now :)
cjp256
approved these changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's just enough scaffolding in place to allow for the plugin to
load.
PluginHandler has been extended to determine when a PluginV2 is being
used (PluginHandler should be renamed to PartHandler).
Some extra attribute were added to PluginV2 to minimize the changes
required in PluginHandler.
Old code handling state file migration in PluginHandler._do_build was
removed as that was done before the migration to bases (meaning that
no base using Snapcraft project needs this).
Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com
./runtests.sh static?./runtests.sh tests/unit?