repo: fix for multi-arch virtual-packages #3084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjp256
force-pushed
the
fix-multi-arch
branch
2 times, most recently
from
5938069
to
65cc0de
Compare
wine-devel-i386 does not have the explicit ":i386" tag, but the virtual package is provided by "wine-devel-i386:i386". Account for this possibility by resolving the package and checking the architecture first, if no arch is specified by the user. - Revert the use of or_dependendencies back to target_versions now that target_arch should correct the previously faulty behavior (where target_versions ended up switching to the incorrect arch after following an :any package). - Fix apt.Package.architectures to architectures() method call. Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
sergiusens
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wine-devel-i386 does not have the explicit ":i386" tag, but
the virtual package is provided by "wine-devel-i386:i386".
Account for this possibility by resolving the package and
checking the architecture first, if no arch is specified by
the user.
Revert the use of or_dependendencies back to target_versions
now that target_arch should correct the previously faulty
behavior (where target_versions ended up switching to the
incorrect arch after following an :any package).
Fix apt.Package.architectures to architectures() method call.
Signed-off-by: Chris Patterson chris.patterson@canonical.com
./runtests.sh static?./runtests.sh tests/unit?